Skip to content

Commit

Permalink
selftests/pidfd: Fix wrong expectation
Browse files Browse the repository at this point in the history
Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
which will be actually tested on the parent and child sides with a
following commit.

Cc: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
Signed-off-by: Mickaël Salaün <mic@digikod.net>
  • Loading branch information
Mickaël Salaün committed May 11, 2024
1 parent cc80aa9 commit 821bc4a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/selftests/pidfd/pidfd_setns_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ FIXTURE_SETUP(current_nsset)
/* Create task that exits right away. */
self->child_pid_exited = create_child(&self->child_pidfd_exited,
CLONE_NEWUSER | CLONE_NEWNET);
EXPECT_GT(self->child_pid_exited, 0);
EXPECT_GE(self->child_pid_exited, 0);

if (self->child_pid_exited == 0)
_exit(EXIT_SUCCESS);
Expand Down

0 comments on commit 821bc4a

Please sign in to comment.