Skip to content

Commit

Permalink
usb: musb: jz4740: Let the platform probe the PHY
Browse files Browse the repository at this point in the history
By registering a generic USB PHY from within the driver, we may shadow
the USB PHY registered by the platform, which might be different.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Paul Cercueil authored and Greg Kroah-Hartman committed Apr 30, 2019
1 parent 70833b8 commit 82257c7
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/usb/musb/jz4740.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ static struct musb_hdrc_platform_data jz4740_musb_platform_data = {

static int jz4740_musb_init(struct musb *musb)
{
usb_phy_generic_register();
musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2);
if (IS_ERR(musb->xceiv)) {
pr_err("HS UDC: no transceiver configured\n");
Expand Down Expand Up @@ -183,7 +182,6 @@ static int jz4740_remove(struct platform_device *pdev)
struct jz4740_glue *glue = platform_get_drvdata(pdev);

platform_device_unregister(glue->musb);
usb_phy_generic_unregister(pdev);
clk_disable_unprepare(glue->clk);

return 0;
Expand Down

0 comments on commit 82257c7

Please sign in to comment.