Skip to content

Commit

Permalink
net: dsa: Drop WARN() in tag_brcm.c
Browse files Browse the repository at this point in the history
We may be able to see invalid Broadcom tags when the hardware and drivers are
misconfigured, or just while exercising the error path. Instead of flooding
the console with messages, flat out drop the packet.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Florian Fainelli authored and David S. Miller committed Jan 24, 2017
1 parent 3ebe834 commit 82272db
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/dsa/tag_brcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ static int brcm_tag_rcv(struct sk_buff *skb, struct net_device *dev,
/* We should never see a reserved reason code without knowing how to
* handle it
*/
WARN_ON(brcm_tag[2] & BRCM_EG_RC_RSVD);
if (unlikely(brcm_tag[2] & BRCM_EG_RC_RSVD))
goto out_drop;

/* Locate which port this is coming from */
source_port = brcm_tag[3] & BRCM_EG_PID_MASK;
Expand Down

0 comments on commit 82272db

Please sign in to comment.