Skip to content

Commit

Permalink
efi: rtc-efi: Mark UIE as unsupported
Browse files Browse the repository at this point in the history
Tools like hwclock attempt to enable the RTC update interrupt (UIE) to
maximize the accuracy of the reported time value. The EFI rtc does not
have interrupt capability so this is a pointless exercise to begin with,
but the generic RTC framework ends up issuing a SetWakeupTime() Runtime
Services call before drawing that conclusion on its own.

Instead, we can mark UIE as unsupported at driver probe time. The net
result is the same, but without the spurious SetWakeupTime() call.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
  • Loading branch information
Ard Biesheuvel authored and Matt Fleming committed Jan 20, 2015
1 parent ddeeefe commit 822a027
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/rtc/rtc-efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ static int __init efi_rtc_probe(struct platform_device *dev)
if (IS_ERR(rtc))
return PTR_ERR(rtc);

rtc->uie_unsupported = 1;
platform_set_drvdata(dev, rtc);

return 0;
Expand Down

0 comments on commit 822a027

Please sign in to comment.