Skip to content

Commit

Permalink
soreuseport: use "unsigned int" in __reuseport_alloc()
Browse files Browse the repository at this point in the history
Number of sockets is limited by 16-bit, so 64-bit allocation will never
happen.

16-bit ops are the worst code density-wise on x86_64 because of
additional prefix (66).

Space savings:

	add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3)
	function                                     old     new   delta
	reuseport_add_sock                           539     536      -3

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexey Dobriyan authored and David S. Miller committed Apr 4, 2017
1 parent ec2e45a commit 822f9bb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/core/sock_reuseport.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

static DEFINE_SPINLOCK(reuseport_lock);

static struct sock_reuseport *__reuseport_alloc(u16 max_socks)
static struct sock_reuseport *__reuseport_alloc(unsigned int max_socks)
{
size_t size = sizeof(struct sock_reuseport) +
unsigned int size = sizeof(struct sock_reuseport) +
sizeof(struct sock *) * max_socks;
struct sock_reuseport *reuse = kzalloc(size, GFP_ATOMIC);

Expand Down

0 comments on commit 822f9bb

Please sign in to comment.