Skip to content

Commit

Permalink
Btrfs: make the logic of source device removing more clear
Browse files Browse the repository at this point in the history
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Chris Mason <clm@fb.com>
  • Loading branch information
Miao Xie authored and Chris Mason committed Sep 17, 2014
1 parent 67a2c45 commit 82372bc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 14 deletions.
3 changes: 1 addition & 2 deletions fs/btrfs/dev-replace.c
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
if (fs_info->fs_devices->latest_bdev == src_device->bdev)
fs_info->fs_devices->latest_bdev = tgt_device->bdev;
list_add(&tgt_device->dev_alloc_list, &fs_info->fs_devices->alloc_list);
if (src_device->fs_devices->seeding)
fs_info->fs_devices->rw_devices++;
fs_info->fs_devices->rw_devices++;

/* replace the sysfs entry */
btrfs_kobj_rm_device(fs_info, src_device);
Expand Down
19 changes: 7 additions & 12 deletions fs/btrfs/volumes.c
Original file line number Diff line number Diff line change
Expand Up @@ -1819,23 +1819,18 @@ void btrfs_rm_dev_replace_srcdev(struct btrfs_fs_info *fs_info,
list_del_rcu(&srcdev->dev_list);
list_del_rcu(&srcdev->dev_alloc_list);
fs_devices->num_devices--;
if (srcdev->missing) {
if (srcdev->missing)
fs_devices->missing_devices--;
if (!fs_devices->seeding)
fs_devices->rw_devices++;

if (srcdev->writeable) {
fs_devices->rw_devices--;
/* zero out the old super if it is writable */
btrfs_scratch_superblock(srcdev);
}

if (srcdev->bdev) {
if (srcdev->bdev)
fs_devices->open_devices--;

/*
* zero out the old super if it is not writable
* (e.g. seed device)
*/
if (srcdev->writeable)
btrfs_scratch_superblock(srcdev);
}

call_rcu(&srcdev->rcu, free_device);

/*
Expand Down

0 comments on commit 82372bc

Please sign in to comment.