Skip to content

Commit

Permalink
tty: serial: Fix refcount leak bug in ucc_uart.c
Browse files Browse the repository at this point in the history
[ Upstream commit d24d7bb ]

In soc_info(), of_find_node_by_type() will return a node pointer
with refcount incremented. We should use of_node_put() when it is
not used anymore.

Acked-by: Timur Tabi <timur@kernel.org>
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220618060850.4058525-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Liang He authored and Greg Kroah-Hartman committed Aug 25, 2022
1 parent 53f62a4 commit 8245e7d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/tty/serial/ucc_uart.c
Original file line number Diff line number Diff line change
Expand Up @@ -1143,6 +1143,8 @@ static unsigned int soc_info(unsigned int *rev_h, unsigned int *rev_l)
/* No compatible property, so try the name. */
soc_string = np->name;

of_node_put(np);

/* Extract the SOC number from the "PowerPC," string */
if ((sscanf(soc_string, "PowerPC,%u", &soc) != 1) || !soc)
return 0;
Expand Down

0 comments on commit 8245e7d

Please sign in to comment.