Skip to content

Commit

Permalink
iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc()
Browse files Browse the repository at this point in the history
Smatch complains about returning hard coded error codes, silence this
warning.

drivers/target/iscsi/iscsi_target_parameters.c:211
   iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Luis de Bethencourt authored and Nicholas Bellinger committed Nov 29, 2015
1 parent 6ba4bd2 commit 82a819e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/target/iscsi/iscsi_target_parameters.c
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr)
if (!pl) {
pr_err("Unable to allocate memory for"
" struct iscsi_param_list.\n");
return -1 ;
return -ENOMEM;
}
INIT_LIST_HEAD(&pl->param_list);
INIT_LIST_HEAD(&pl->extra_response_list);
Expand Down Expand Up @@ -578,7 +578,7 @@ int iscsi_copy_param_list(
param_list = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL);
if (!param_list) {
pr_err("Unable to allocate memory for struct iscsi_param_list.\n");
return -1;
return -ENOMEM;
}
INIT_LIST_HEAD(&param_list->param_list);
INIT_LIST_HEAD(&param_list->extra_response_list);
Expand Down Expand Up @@ -629,7 +629,7 @@ int iscsi_copy_param_list(

err_out:
iscsi_release_param_list(param_list);
return -1;
return -ENOMEM;
}

static void iscsi_release_extra_responses(struct iscsi_param_list *param_list)
Expand Down Expand Up @@ -729,7 +729,7 @@ static int iscsi_add_notunderstood_response(
if (!extra_response) {
pr_err("Unable to allocate memory for"
" struct iscsi_extra_response.\n");
return -1;
return -ENOMEM;
}
INIT_LIST_HEAD(&extra_response->er_list);

Expand Down Expand Up @@ -1370,7 +1370,7 @@ int iscsi_decode_text_input(
tmpbuf = kzalloc(length + 1, GFP_KERNEL);
if (!tmpbuf) {
pr_err("Unable to allocate %u + 1 bytes for tmpbuf.\n", length);
return -1;
return -ENOMEM;
}

memcpy(tmpbuf, textbuf, length);
Expand Down

0 comments on commit 82a819e

Please sign in to comment.