Skip to content

Commit

Permalink
drivers/net/wimax/i2400m/fw.c: fix error return code
Browse files Browse the repository at this point in the history
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret;
expression e1,e2;
@@

if (ret < 0)
 { ... return ret; }
 ... when != ret = e1
     when forall
*if(...)
 {
  ... when != ret = e2
* return ret;
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Aug 20, 2012
1 parent b3f0db1 commit 82a820e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/wimax/i2400m/fw.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,10 @@ int i2400m_barker_db_init(const char *_options)
unsigned barker;

options_orig = kstrdup(_options, GFP_KERNEL);
if (options_orig == NULL)
if (options_orig == NULL) {
result = -ENOMEM;
goto error_parse;
}
options = options_orig;

while ((token = strsep(&options, ",")) != NULL) {
Expand Down

0 comments on commit 82a820e

Please sign in to comment.