Skip to content

Commit

Permalink
perf tools: Move QUIET_STDERR def to before first use
Browse files Browse the repository at this point in the history
QUIET_STDERR is used when detecting if -fstack-protector-all can
be used.

Noticed while building the perf tools on a Debian PARISC64
machine.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1263293910-8484-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed Jan 13, 2010
1 parent c2c5d45 commit 8303951
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions tools/perf/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,12 @@ PTHREAD_LIBS = -lpthread
# explicitly what architecture to check for. Fix this up for yours..
SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__

ifeq ($(V), 2)
QUIET_STDERR = ">/dev/null"
else
QUIET_STDERR = ">/dev/null 2>&1"
endif

ifeq ($(shell sh -c "echo 'int foo(void) {char X[2]; return 3;}' | $(CC) -x c -c -Werror -fstack-protector-all - -o /dev/null "$(QUIET_STDERR)" && echo y"), y)
CFLAGS := $(CFLAGS) -fstack-protector-all
endif
Expand Down Expand Up @@ -451,11 +457,6 @@ BUILTIN_OBJS += builtin-kmem.o

PERFLIBS = $(LIB_FILE)

ifeq ($(V), 2)
QUIET_STDERR = ">/dev/null"
else
QUIET_STDERR = ">/dev/null 2>&1"
endif
#
# Platform specific tweaks
#
Expand Down

0 comments on commit 8303951

Please sign in to comment.