Skip to content

Commit

Permalink
selftests/powerpc: Remove Power9 copy_unaligned test
Browse files Browse the repository at this point in the history
This is a test of the ISA 3.0 "copy" instruction. That instruction has
an L field, which if set to 1 specifies that "the instruction
identifies the beginning of a move group" (pp 858). That's also
referred to as "copy first" vs "copy".

In ISA 3.0B the copy instruction does not have an L field, and the
corresponding bit in the instruction must be set to 1.

This test is generating a "copy" instruction, not a "copy first", and
so on Power9 (which implements 3.0B), this results in an illegal
instruction.

So just drop the test entirely. We still have copy_first_unaligned to
test the "copy first" behaviour.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Michael Ellerman committed Jul 20, 2018
1 parent ec93363 commit 83039f2
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 43 deletions.
1 change: 0 additions & 1 deletion tools/testing/selftests/powerpc/alignment/.gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
copy_unaligned
copy_first_unaligned
paste_unaligned
paste_last_unaligned
Expand Down
2 changes: 1 addition & 1 deletion tools/testing/selftests/powerpc/alignment/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
TEST_GEN_PROGS := copy_unaligned copy_first_unaligned paste_unaligned \
TEST_GEN_PROGS := copy_first_unaligned paste_unaligned \
paste_last_unaligned alignment_handler

include ../../lib.mk
Expand Down
41 changes: 0 additions & 41 deletions tools/testing/selftests/powerpc/alignment/copy_unaligned.c

This file was deleted.

0 comments on commit 83039f2

Please sign in to comment.