Skip to content

Commit

Permalink
Revert: "vfio-pci: Mask INTx if a device is not capabable of enabling…
Browse files Browse the repository at this point in the history
… it"

This reverts commit 2170dd0

The intent of commit 2170dd0 ("vfio-pci: Mask INTx if a device is
not capabable of enabling it") was to disallow the user from seeing
that the device supports INTx if the platform is incapable of enabling
it.  The detection of this case however incorrectly includes devices
which natively do not support INTx, such as SR-IOV VFs, and further
discussions reveal gaps even for the target use case.

Reported-by: Arjun Vynipadath <arjun@chelsio.com>
Fixes: 2170dd0 ("vfio-pci: Mask INTx if a device is not capabable of enabling it")
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
  • Loading branch information
Alex Williamson committed Mar 22, 2018
1 parent c698ca5 commit 834814e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/vfio/pci/vfio_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,6 @@ static bool vfio_pci_nointx(struct pci_dev *pdev)
}
}

if (!pdev->irq)
return true;

return false;
}

Expand Down

0 comments on commit 834814e

Please sign in to comment.