Skip to content

Commit

Permalink
drm/edid: Add packed attribute to new gtf2 and cvt structs
Browse files Browse the repository at this point in the history
The new structs added in struct detailed_data_monitor_range must be
marked with packed attribute although the outer struct itself is
already marked as packed.  Otherwise these 7-bytes structs may be
aligned, and give the wrong position and size for the data.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
Takashi Iwai authored and Dave Airlie committed Apr 23, 2012
1 parent c09dedb commit 8353e6c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/drm/drm_edid.h
Original file line number Diff line number Diff line change
@@ -99,7 +99,7 @@ struct detailed_data_monitor_range {
__le16 m;
u8 k;
u8 j; /* need to divide by 2 */
} gtf2;
} __attribute__((packed)) gtf2;
struct {
u8 version;
u8 data1; /* high 6 bits: extra clock resolution */
@@ -108,7 +108,7 @@ struct detailed_data_monitor_range {
u8 flags; /* preferred aspect and blanking support */
u8 supported_scalings;
u8 preferred_refresh;
} cvt;
} __attribute__((packed)) cvt;
} formula;
} __attribute__((packed));

0 comments on commit 8353e6c

Please sign in to comment.