Skip to content

Commit

Permalink
power: Switch back to struct platform_driver::remove()
Browse files Browse the repository at this point in the history
After commit 0edb555 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/power/ to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

While touching these files, make indention of the struct initializer
consistent in several files.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20241010203622.839625-6-u.kleine-koenig@baylibre.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
  • Loading branch information
Uwe Kleine-König authored and Sebastian Reichel committed Oct 21, 2024
1 parent 44fcc47 commit 83bce34
Show file tree
Hide file tree
Showing 33 changed files with 36 additions and 36 deletions.
2 changes: 1 addition & 1 deletion drivers/power/reset/at91-poweroff.c
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ MODULE_DEVICE_TABLE(of, at91_poweroff_of_match);

static struct platform_driver at91_poweroff_driver = {
.probe = at91_poweroff_probe,
.remove_new = at91_poweroff_remove,
.remove = at91_poweroff_remove,
.driver = {
.name = "at91-poweroff",
.of_match_table = at91_poweroff_of_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/reset/at91-reset.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ static void at91_reset_remove(struct platform_device *pdev)

static struct platform_driver at91_reset_driver = {
.probe = at91_reset_probe,
.remove_new = at91_reset_remove,
.remove = at91_reset_remove,
.driver = {
.name = "at91-reset",
.of_match_table = at91_reset_of_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/reset/at91-sama5d2_shdwc.c
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ static void at91_shdwc_remove(struct platform_device *pdev)

static struct platform_driver at91_shdwc_driver = {
.probe = at91_shdwc_probe,
.remove_new = at91_shdwc_remove,
.remove = at91_shdwc_remove,
.driver = {
.name = "at91-shdwc",
.of_match_table = at91_shdwc_of_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/reset/ltc2952-poweroff.c
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ MODULE_DEVICE_TABLE(of, of_ltc2952_poweroff_match);

static struct platform_driver ltc2952_poweroff_driver = {
.probe = ltc2952_poweroff_probe,
.remove_new = ltc2952_poweroff_remove,
.remove = ltc2952_poweroff_remove,
.driver = {
.name = "ltc2952-poweroff",
.of_match_table = of_ltc2952_poweroff_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/reset/qnap-poweroff.c
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ static void qnap_power_off_remove(struct platform_device *pdev)

static struct platform_driver qnap_power_off_driver = {
.probe = qnap_power_off_probe,
.remove_new = qnap_power_off_remove,
.remove = qnap_power_off_remove,
.driver = {
.name = "qnap_power_off",
.of_match_table = of_match_ptr(qnap_power_off_of_match_table),
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/ab8500_btemp.c
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ MODULE_DEVICE_TABLE(of, ab8500_btemp_match);

struct platform_driver ab8500_btemp_driver = {
.probe = ab8500_btemp_probe,
.remove_new = ab8500_btemp_remove,
.remove = ab8500_btemp_remove,
.driver = {
.name = "ab8500-btemp",
.of_match_table = ab8500_btemp_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/ab8500_chargalg.c
Original file line number Diff line number Diff line change
Expand Up @@ -1837,7 +1837,7 @@ static const struct of_device_id ab8500_chargalg_match[] = {

struct platform_driver ab8500_chargalg_driver = {
.probe = ab8500_chargalg_probe,
.remove_new = ab8500_chargalg_remove,
.remove = ab8500_chargalg_remove,
.driver = {
.name = "ab8500_chargalg",
.of_match_table = ab8500_chargalg_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/ab8500_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -3711,7 +3711,7 @@ MODULE_DEVICE_TABLE(of, ab8500_charger_match);

static struct platform_driver ab8500_charger_driver = {
.probe = ab8500_charger_probe,
.remove_new = ab8500_charger_remove,
.remove = ab8500_charger_remove,
.driver = {
.name = "ab8500-charger",
.of_match_table = ab8500_charger_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/ab8500_fg.c
Original file line number Diff line number Diff line change
Expand Up @@ -3242,7 +3242,7 @@ MODULE_DEVICE_TABLE(of, ab8500_fg_match);

struct platform_driver ab8500_fg_driver = {
.probe = ab8500_fg_probe,
.remove_new = ab8500_fg_remove,
.remove = ab8500_fg_remove,
.driver = {
.name = "ab8500-fg",
.of_match_table = ab8500_fg_match,
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/acer_a500_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ static struct platform_driver a500_battery_driver = {
.pm = &a500_battery_pm_ops,
},
.probe = a500_battery_probe,
.remove_new = a500_battery_remove,
.remove = a500_battery_remove,
};
module_platform_driver(a500_battery_driver);

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/act8945a_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ static struct platform_driver act8945a_charger_driver = {
.name = "act8945a-charger",
},
.probe = act8945a_charger_probe,
.remove_new = act8945a_charger_remove,
.remove = act8945a_charger_remove,
};
module_platform_driver(act8945a_charger_driver);

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/charger-manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,7 @@ static struct platform_driver charger_manager_driver = {
.of_match_table = charger_manager_match,
},
.probe = charger_manager_probe,
.remove_new = charger_manager_remove,
.remove = charger_manager_remove,
.id_table = charger_manager_id,
};

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/cpcap-battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,7 @@ static struct platform_driver cpcap_battery_driver = {
.of_match_table = of_match_ptr(cpcap_battery_id_table),
},
.probe = cpcap_battery_probe,
.remove_new = cpcap_battery_remove,
.remove = cpcap_battery_remove,
};
module_platform_driver(cpcap_battery_driver);

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/cpcap-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -969,7 +969,7 @@ static struct platform_driver cpcap_charger_driver = {
.of_match_table = cpcap_charger_id_table,
},
.shutdown = cpcap_charger_shutdown,
.remove_new = cpcap_charger_remove,
.remove = cpcap_charger_remove,
};
module_platform_driver(cpcap_charger_driver);

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/da9030_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ static struct platform_driver da903x_battery_driver = {
.name = "da903x-battery",
},
.probe = da9030_battery_probe,
.remove_new = da9030_battery_remove,
.remove = da9030_battery_remove,
};

module_platform_driver(da903x_battery_driver);
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/da9052-battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ static void da9052_bat_remove(struct platform_device *pdev)

static struct platform_driver da9052_bat_driver = {
.probe = da9052_bat_probe,
.remove_new = da9052_bat_remove,
.remove = da9052_bat_remove,
.driver = {
.name = "da9052-bat",
},
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/da9150-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ static struct platform_driver da9150_charger_driver = {
.name = "da9150-charger",
},
.probe = da9150_charger_probe,
.remove_new = da9150_charger_remove,
.remove = da9150_charger_remove,
};

module_platform_driver(da9150_charger_driver);
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/ipaq_micro_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ static struct platform_driver micro_batt_device_driver = {
.pm = &micro_batt_dev_pm_ops,
},
.probe = micro_batt_probe,
.remove_new = micro_batt_remove,
.remove = micro_batt_remove,
};
module_platform_driver(micro_batt_device_driver);

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/isp1704_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ static struct platform_driver isp1704_charger_driver = {
.of_match_table = of_match_ptr(omap_isp1704_of_match),
},
.probe = isp1704_charger_probe,
.remove_new = isp1704_charger_remove,
.remove = isp1704_charger_remove,
};

module_platform_driver(isp1704_charger_driver);
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/lp8788-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ static void lp8788_charger_remove(struct platform_device *pdev)

static struct platform_driver lp8788_charger_driver = {
.probe = lp8788_charger_probe,
.remove_new = lp8788_charger_remove,
.remove = lp8788_charger_remove,
.driver = {
.name = LP8788_DEV_CHARGER,
},
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/max14577_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ static struct platform_driver max14577_charger_driver = {
.of_match_table = of_max14577_charger_dt_match,
},
.probe = max14577_charger_probe,
.remove_new = max14577_charger_remove,
.remove = max14577_charger_remove,
.id_table = max14577_charger_id,
};
module_platform_driver(max14577_charger_driver);
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/max77650-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ static struct platform_driver max77650_charger_driver = {
.of_match_table = max77650_charger_of_match,
},
.probe = max77650_charger_probe,
.remove_new = max77650_charger_remove,
.remove = max77650_charger_remove,
};
module_platform_driver(max77650_charger_driver);

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/max77693_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ static struct platform_driver max77693_charger_driver = {
.name = "max77693-charger",
},
.probe = max77693_charger_probe,
.remove_new = max77693_charger_remove,
.remove = max77693_charger_remove,
.id_table = max77693_charger_id,
};
module_platform_driver(max77693_charger_driver);
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/max8925_power.c
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ static void max8925_power_remove(struct platform_device *pdev)

static struct platform_driver max8925_power_driver = {
.probe = max8925_power_probe,
.remove_new = max8925_power_remove,
.remove = max8925_power_remove,
.driver = {
.name = "max8925-power",
},
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/pcf50633-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ static struct platform_driver pcf50633_mbc_driver = {
.name = "pcf50633-mbc",
},
.probe = pcf50633_mbc_probe,
.remove_new = pcf50633_mbc_remove,
.remove = pcf50633_mbc_remove,
};

module_platform_driver(pcf50633_mbc_driver);
Expand Down
8 changes: 4 additions & 4 deletions drivers/power/supply/qcom_smbb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1017,10 +1017,10 @@ static const struct of_device_id smbb_charger_id_table[] = {
MODULE_DEVICE_TABLE(of, smbb_charger_id_table);

static struct platform_driver smbb_charger_driver = {
.probe = smbb_charger_probe,
.remove_new = smbb_charger_remove,
.driver = {
.name = "qcom-smbb",
.probe = smbb_charger_probe,
.remove = smbb_charger_remove,
.driver = {
.name = "qcom-smbb",
.of_match_table = smbb_charger_id_table,
},
};
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/sc2731_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ static struct platform_driver sc2731_charger_driver = {
.of_match_table = sc2731_charger_of_match,
},
.probe = sc2731_charger_probe,
.remove_new = sc2731_charger_remove,
.remove = sc2731_charger_remove,
};

module_platform_driver(sc2731_charger_driver);
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/tps65090-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ static struct platform_driver tps65090_charger_driver = {
.of_match_table = of_tps65090_charger_match,
},
.probe = tps65090_charger_probe,
.remove_new = tps65090_charger_remove,
.remove = tps65090_charger_remove,
};
module_platform_driver(tps65090_charger_driver);

Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/tps65217_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ MODULE_DEVICE_TABLE(of, tps65217_charger_match_table);

static struct platform_driver tps65217_charger_driver = {
.probe = tps65217_charger_probe,
.remove_new = tps65217_charger_remove,
.remove = tps65217_charger_remove,
.driver = {
.name = "tps65217-charger",
.of_match_table = of_match_ptr(tps65217_charger_match_table),
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/twl4030_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@ MODULE_DEVICE_TABLE(of, twl_bci_of_match);

static struct platform_driver twl4030_bci_driver = {
.probe = twl4030_bci_probe,
.remove_new = twl4030_bci_remove,
.remove = twl4030_bci_remove,
.driver = {
.name = "twl4030_bci",
.of_match_table = of_match_ptr(twl_bci_of_match),
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/wm831x_power.c
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ static void wm831x_power_remove(struct platform_device *pdev)

static struct platform_driver wm831x_power_driver = {
.probe = wm831x_power_probe,
.remove_new = wm831x_power_remove,
.remove = wm831x_power_remove,
.driver = {
.name = "wm831x-power",
},
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/wm8350_power.c
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ static void wm8350_power_remove(struct platform_device *pdev)

static struct platform_driver wm8350_power_driver = {
.probe = wm8350_power_probe,
.remove_new = wm8350_power_remove,
.remove = wm8350_power_remove,
.driver = {
.name = "wm8350-power",
},
Expand Down
2 changes: 1 addition & 1 deletion drivers/power/supply/wm97xx_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ static struct platform_driver wm97xx_bat_driver = {
#endif
},
.probe = wm97xx_bat_probe,
.remove_new = wm97xx_bat_remove,
.remove = wm97xx_bat_remove,
};

module_platform_driver(wm97xx_bat_driver);
Expand Down

0 comments on commit 83bce34

Please sign in to comment.