Skip to content

Commit

Permalink
Merge branch 'for-4.20' of git://git.kernel.org/pub/scm/linux/kernel/…
Browse files Browse the repository at this point in the history
…git/tj/cgroup

Pull cgroup updates from Tejun Heo:
 "All trivial changes - simplification, typo fix and adding
  cond_resched() in a netclassid update loop"

* 'for-4.20' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup:
  cgroup, netclassid: add a preemption point to write_classid
  rdmacg: fix a typo in rdmacg documentation
  cgroup: Simplify cgroup_ancestor
  • Loading branch information
Linus Torvalds committed Oct 26, 2018
2 parents a67eefa + a90e90b commit 83c4087
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
2 changes: 1 addition & 1 deletion Documentation/cgroup-v1/rdma.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ cgroup.
Currently user space applications can easily take away all the rdma verb
specific resources such as AH, CQ, QP, MR etc. Due to which other applications
in other cgroup or kernel space ULPs may not even get chance to allocate any
rdma resources. This can leads to service unavailability.
rdma resources. This can lead to service unavailability.

Therefore RDMA controller is needed through which resource consumption
of processes can be limited. Through this controller different rdma
Expand Down
15 changes: 3 additions & 12 deletions include/linux/cgroup.h
Original file line number Diff line number Diff line change
Expand Up @@ -569,20 +569,11 @@ static inline bool cgroup_is_descendant(struct cgroup *cgrp,
static inline struct cgroup *cgroup_ancestor(struct cgroup *cgrp,
int ancestor_level)
{
struct cgroup *ptr;

if (cgrp->level < ancestor_level)
return NULL;

for (ptr = cgrp;
ptr && ptr->level > ancestor_level;
ptr = cgroup_parent(ptr))
;

if (ptr && ptr->level == ancestor_level)
return ptr;

return NULL;
while (cgrp && cgrp->level > ancestor_level)
cgrp = cgroup_parent(cgrp);
return cgrp;
}

/**
Expand Down
1 change: 1 addition & 0 deletions net/core/netclassid_cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ static int write_classid(struct cgroup_subsys_state *css, struct cftype *cft,
iterate_fd(p->files, 0, update_classid_sock,
(void *)(unsigned long)cs->classid);
task_unlock(p);
cond_resched();
}
css_task_iter_end(&it);

Expand Down

0 comments on commit 83c4087

Please sign in to comment.