Skip to content

Commit

Permalink
iommu/arm-smmu: put iommu_domain pointer in dev->archdata.iommu
Browse files Browse the repository at this point in the history
In preparation for nested translation support, stick a pointer to the
iommu_domain in dev->archdata.iommu. This makes it much easier to grab
hold of the physical group configuration (e.g. cbndx) when dealing with
vSMMU accesses from a guest.

Signed-off-by: Will Deacon <will.deacon@arm.com>
  • Loading branch information
Will Deacon committed Sep 16, 2014
1 parent 8f68f8e commit 844e35b
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions drivers/iommu/arm-smmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,11 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)
return -ENXIO;
}

if (dev->archdata.iommu) {
dev_err(dev, "already attached to IOMMU domain\n");
return -EEXIST;
}

/*
* Sanity check the domain. We don't support domains across
* different SMMUs.
Expand All @@ -1239,7 +1244,10 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)
if (!cfg)
return -ENODEV;

return arm_smmu_domain_add_master(smmu_domain, cfg);
ret = arm_smmu_domain_add_master(smmu_domain, cfg);
if (!ret)
dev->archdata.iommu = domain;
return ret;
}

static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev)
Expand All @@ -1248,8 +1256,11 @@ static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev)
struct arm_smmu_master_cfg *cfg;

cfg = find_smmu_master_cfg(dev);
if (cfg)
arm_smmu_domain_remove_master(smmu_domain, cfg);
if (!cfg)
return;

dev->archdata.iommu = NULL;
arm_smmu_domain_remove_master(smmu_domain, cfg);
}

static bool arm_smmu_pte_is_contiguous_range(unsigned long addr,
Expand Down

0 comments on commit 844e35b

Please sign in to comment.