Skip to content

Commit

Permalink
rtnetlink: Fix missing error code in rtnl_bridge_notify()
Browse files Browse the repository at this point in the history
[ Upstream commit a8db57c ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.

Eliminate the follow smatch warning:

net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Jiapeng Chong authored and Greg Kroah-Hartman committed Jun 18, 2021
1 parent abc57d8 commit 8478b36
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/core/rtnetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -4833,8 +4833,10 @@ static int rtnl_bridge_notify(struct net_device *dev)
if (err < 0)
goto errout;

if (!skb->len)
if (!skb->len) {
err = -EINVAL;
goto errout;
}

rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
return 0;
Expand Down

0 comments on commit 8478b36

Please sign in to comment.