Skip to content

Commit

Permalink
powerpc/mpc5200: fix bestcomm Kconfig dependencies
Browse files Browse the repository at this point in the history
Without this patch it is possible to select drivers which require
bestcomm support without bestcomm support being selected.  This
patch reworks the bestcomm dependencies to ensure the correct
bestcomm tasks are always enabled.

Reported-by: Hans Lehmann <hans.lehmann@ritter-elektronik.de>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Grant Likely committed Nov 14, 2008
1 parent 4ffaf86 commit 847cdf4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
9 changes: 3 additions & 6 deletions arch/powerpc/sysdev/bestcomm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,20 @@ config PPC_BESTCOMM
answer Y or M. Otherwise say N.

config PPC_BESTCOMM_ATA
tristate "Bestcomm ATA task support"
tristate
depends on PPC_BESTCOMM
default n
help
This option enables the support for the ATA task.

config PPC_BESTCOMM_FEC
tristate "Bestcomm FEC tasks support"
tristate
depends on PPC_BESTCOMM
default n
help
This option enables the support for the FEC tasks.

config PPC_BESTCOMM_GEN_BD
tristate "Bestcomm GenBD tasks support"
tristate
depends on PPC_BESTCOMM
default n
help
This option enables the support for the GenBD tasks.

3 changes: 2 additions & 1 deletion drivers/net/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1825,9 +1825,10 @@ config FEC2

config FEC_MPC52xx
tristate "MPC52xx FEC driver"
depends on PPC_MPC52xx && PPC_BESTCOMM_FEC
depends on PPC_MPC52xx && PPC_BESTCOMM
select CRC32
select PHYLIB
select PPC_BESTCOMM_FEC
---help---
This option enables support for the MPC5200's on-chip
Fast Ethernet Controller
Expand Down
3 changes: 2 additions & 1 deletion sound/soc/fsl/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ config SND_SOC_MPC8610_HPCD

config SND_SOC_MPC5200_I2S
tristate "Freescale MPC5200 PSC in I2S mode driver"
depends on SND_SOC && PPC_MPC52xx && PPC_BESTCOMM
select SND_SOC_OF_SIMPLE
depends on SND_SOC && PPC_MPC52xx
select PPC_BESTCOMM_GEN_BD
help
Say Y here to support the MPC5200 PSCs in I2S mode.

0 comments on commit 847cdf4

Please sign in to comment.