Skip to content

Commit

Permalink
drm/i915: only apply crt_present check on VLV
Browse files Browse the repository at this point in the history
Apparently we can't trust this field on other platforms and need to find
some other way.

This fixes a regression introduced in
commit 27da3bd
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Fri Apr 4 16:12:07 2014 -0700

    drm/i915: use VBT to determine whether to enumerate the VGA port

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
  • Loading branch information
Jesse Barnes authored and Jani Nikula committed Jun 30, 2014
1 parent 33c3b0d commit 84b4e04
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -11097,6 +11097,22 @@ const char *intel_output_name(int output)
return names[output];
}

static bool intel_crt_present(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;

if (IS_ULT(dev))
return false;

if (IS_CHERRYVIEW(dev))
return false;

if (IS_VALLEYVIEW(dev) && !dev_priv->vbt.int_crt_support)
return false;

return true;
}

static void intel_setup_outputs(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;
Expand All @@ -11105,7 +11121,7 @@ static void intel_setup_outputs(struct drm_device *dev)

intel_lvds_init(dev);

if (!IS_ULT(dev) && !IS_CHERRYVIEW(dev) && dev_priv->vbt.int_crt_support)
if (intel_crt_present(dev))
intel_crt_init(dev);

if (HAS_DDI(dev)) {
Expand Down

0 comments on commit 84b4e04

Please sign in to comment.