Skip to content

Commit

Permalink
wifi: ath12k: prepare vif config caching for MLO
Browse files Browse the repository at this point in the history 
Currently vif configuration cache pointers are placed in arvif and caching is
done whenever a link vif configuration is received before driver created vdev
for it (i.e. before channel is assigned), this is possible because current code
only uses default link (ahvif->deflink) which is preallocated.

With MLO changes the ieee80211_vif drv priv is now ahvif and its arvifs (struct
ath12k_link_vif) other than deflink can be allocated dynamically during channel
assignment.  Hence maintain link level cache in ahvif and whenever channel is
assigned for link vif and vdev is created, flush the corresponding link vif
cache from ahvif.

Current code uses cache of ATH12K_DEFAULT_LINK_ID (0) which is the cache of
ahvif->deflink.

Co-developed-by: Sriram R <quic_srirrama@quicinc.com>
Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20241015171416.518022-5-kvalo@kernel.org
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
  • Loading branch information
Rameshkumar Sundaram authored and Jeff Johnson committed Oct 16, 2024
1 parent b89b5db commit 84c5971
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 20 deletions.
2 changes: 1 addition & 1 deletion drivers/net/wireless/ath/ath12k/core.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ struct ath12k_link_vif {
u32 punct_bitmap;
u8 link_id;
struct ath12k_vif *ahvif;
struct ath12k_vif_cache *cache;
struct ath12k_rekey_data rekey_data;
};

Expand Down Expand Up @@ -307,6 +306,7 @@ struct ath12k_vif {

struct ath12k_link_vif deflink;
struct ath12k_link_vif __rcu *link[IEEE80211_MLD_MAX_NUM_LINKS];
struct ath12k_vif_cache *cache[IEEE80211_MLD_MAX_NUM_LINKS];
/* indicates bitmap of link vif created in FW */
u16 links_map;

Expand Down
40 changes: 21 additions & 19 deletions drivers/net/wireless/ath/ath12k/mac.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3464,18 +3464,19 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar,
}
}

static struct ath12k_vif_cache *ath12k_arvif_get_cache(struct ath12k_link_vif *arvif)
static struct ath12k_vif_cache *ath12k_ahvif_get_link_cache(struct ath12k_vif *ahvif,
u8 link_id)
{
if (!arvif->cache)
arvif->cache = kzalloc(sizeof(*arvif->cache), GFP_KERNEL);
if (!ahvif->cache[link_id])
ahvif->cache[link_id] = kzalloc(sizeof(*ahvif->cache[0]), GFP_KERNEL);

return arvif->cache;
return ahvif->cache[link_id];
}

static void ath12k_arvif_put_cache(struct ath12k_link_vif *arvif)
static void ath12k_ahvif_put_link_cache(struct ath12k_vif *ahvif, u8 link_id)
{
kfree(arvif->cache);
arvif->cache = NULL;
kfree(ahvif->cache[link_id]);
ahvif->cache[link_id] = NULL;
}

static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
Expand All @@ -3502,14 +3503,13 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw,

if (!ar) {
/* TODO Once link vif is fetched based on link id from
* info, avoid using the deflink above and cache the link
* configs in ahvif per link.
* info, avoid using ATH12K_DEFAULT_LINK_ID.
*/
cache = ath12k_arvif_get_cache(arvif);
cache = ath12k_ahvif_get_link_cache(ahvif, ATH12K_DEFAULT_LINK_ID);
if (!cache)
return;

arvif->cache->bss_conf_changed |= changed;
cache->bss_conf_changed |= changed;

return;
}
Expand Down Expand Up @@ -4157,7 +4157,7 @@ static int ath12k_mac_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
return -EINVAL;
}

cache = ath12k_arvif_get_cache(arvif);
cache = ath12k_ahvif_get_link_cache(ahvif, ATH12K_DEFAULT_LINK_ID);
if (!cache)
return -ENOSPC;

Expand Down Expand Up @@ -5074,7 +5074,7 @@ static int ath12k_mac_op_conf_tx(struct ieee80211_hw *hw,
ar = ath12k_get_ar_by_vif(hw, vif);
if (!ar) {
/* cache the info and apply after vdev is created */
cache = ath12k_arvif_get_cache(arvif);
cache = ath12k_ahvif_get_link_cache(ahvif, ATH12K_DEFAULT_LINK_ID);
if (!cache)
return -ENOSPC;

Expand Down Expand Up @@ -6790,10 +6790,11 @@ int ath12k_mac_vdev_create(struct ath12k *ar, struct ath12k_link_vif *arvif)
return ret;
}

static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ath12k_link_vif *arvif)
static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ath12k_link_vif *arvif)
{
struct ieee80211_vif *vif = ath12k_ahvif_to_vif(arvif->ahvif);
struct ath12k_vif_cache *cache = arvif->cache;
struct ath12k_vif *ahvif = arvif->ahvif;
struct ieee80211_vif *vif = ath12k_ahvif_to_vif(ahvif);
struct ath12k_vif_cache *cache = ahvif->cache[arvif->link_id];
struct ath12k_base *ab = ar->ab;

int ret;
Expand Down Expand Up @@ -6824,7 +6825,7 @@ static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ath12k_link_vi
ath12k_warn(ab, "unable to apply set key param to vdev %d ret %d\n",
arvif->vdev_id, ret);
}
ath12k_arvif_put_cache(arvif);
ath12k_ahvif_put_link_cache(ahvif, arvif->link_id);
}

static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw,
Expand Down Expand Up @@ -7028,7 +7029,7 @@ static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ath12k_link_vif *arv
spin_unlock_bh(&ar->data_lock);

ath12k_peer_cleanup(ar, arvif->vdev_id);
ath12k_arvif_put_cache(arvif);
ath12k_ahvif_put_link_cache(ahvif, arvif->link_id);

idr_for_each(&ar->txmgmt_idr,
ath12k_mac_vif_txmgmt_idr_remove, vif);
Expand Down Expand Up @@ -7069,7 +7070,8 @@ static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw,
/* if we cached some config but never received assign chanctx,
* free the allocated cache.
*/
ath12k_arvif_put_cache(arvif);
ath12k_ahvif_put_link_cache(ahvif, ATH12K_DEFAULT_LINK_ID);

return;
}

Expand Down

0 comments on commit 84c5971

Please sign in to comment.