Skip to content

Commit

Permalink
ALSA: firewire-lib: rename PCM format helper function
Browse files Browse the repository at this point in the history
Setting the format of PCM substream to AMDTP stream structure is important
to set a handler to copy actual PCM samples between buffers. The
processing should be in data block processing layer because essentially
it has no relationship to packet streaming.

This commit renames PCM format setting function to prepare for integrating
AM824 layer.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Sakamoto authored and Takashi Iwai committed Sep 29, 2015
1 parent 03e2a67 commit 85130cb
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 18 deletions.
7 changes: 3 additions & 4 deletions sound/firewire/amdtp-stream.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,16 +272,15 @@ static void read_pcm_s32(struct amdtp_stream *s,
__be32 *buffer, unsigned int frames);

/**
* amdtp_stream_set_pcm_format - set the PCM format
* amdtp_am824_set_pcm_format - set the PCM format
* @s: the AMDTP stream to configure
* @format: the format of the ALSA PCM device
*
* The sample format must be set after the other parameters (rate/PCM channels/
* MIDI) and before the stream is started, and must not be changed while the
* stream is running.
*/
void amdtp_stream_set_pcm_format(struct amdtp_stream *s,
snd_pcm_format_t format)
void amdtp_am824_set_pcm_format(struct amdtp_stream *s, snd_pcm_format_t format)
{
if (WARN_ON(amdtp_stream_pcm_running(s)))
return;
Expand All @@ -305,7 +304,7 @@ void amdtp_stream_set_pcm_format(struct amdtp_stream *s,
break;
}
}
EXPORT_SYMBOL(amdtp_stream_set_pcm_format);
EXPORT_SYMBOL_GPL(amdtp_am824_set_pcm_format);

/**
* amdtp_stream_pcm_prepare - prepare PCM device for running
Expand Down
4 changes: 2 additions & 2 deletions sound/firewire/amdtp-stream.h
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ void amdtp_stream_stop(struct amdtp_stream *s);

int amdtp_stream_add_pcm_hw_constraints(struct amdtp_stream *s,
struct snd_pcm_runtime *runtime);
void amdtp_stream_set_pcm_format(struct amdtp_stream *s,
snd_pcm_format_t format);
void amdtp_am824_set_pcm_format(struct amdtp_stream *s,
snd_pcm_format_t format);
void amdtp_stream_pcm_prepare(struct amdtp_stream *s);
unsigned long amdtp_stream_pcm_pointer(struct amdtp_stream *s);
void amdtp_stream_pcm_abort(struct amdtp_stream *s);
Expand Down
8 changes: 4 additions & 4 deletions sound/firewire/bebob/bebob_pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ pcm_capture_hw_params(struct snd_pcm_substream *substream,

if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN)
atomic_inc(&bebob->substreams_counter);
amdtp_stream_set_pcm_format(&bebob->tx_stream,
params_format(hw_params));

amdtp_am824_set_pcm_format(&bebob->tx_stream, params_format(hw_params));

return 0;
}
Expand All @@ -239,8 +239,8 @@ pcm_playback_hw_params(struct snd_pcm_substream *substream,

if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN)
atomic_inc(&bebob->substreams_counter);
amdtp_stream_set_pcm_format(&bebob->rx_stream,
params_format(hw_params));

amdtp_am824_set_pcm_format(&bebob->rx_stream, params_format(hw_params));

return 0;
}
Expand Down
6 changes: 2 additions & 4 deletions sound/firewire/dice/dice-pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,7 @@ static int capture_hw_params(struct snd_pcm_substream *substream,
mutex_unlock(&dice->mutex);
}

amdtp_stream_set_pcm_format(&dice->tx_stream,
params_format(hw_params));
amdtp_am824_set_pcm_format(&dice->tx_stream, params_format(hw_params));

return 0;
}
Expand All @@ -265,8 +264,7 @@ static int playback_hw_params(struct snd_pcm_substream *substream,
mutex_unlock(&dice->mutex);
}

amdtp_stream_set_pcm_format(&dice->rx_stream,
params_format(hw_params));
amdtp_am824_set_pcm_format(&dice->rx_stream, params_format(hw_params));

return 0;
}
Expand Down
6 changes: 4 additions & 2 deletions sound/firewire/fireworks/fireworks_pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ static int pcm_capture_hw_params(struct snd_pcm_substream *substream,

if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN)
atomic_inc(&efw->capture_substreams);
amdtp_stream_set_pcm_format(&efw->tx_stream, params_format(hw_params));

amdtp_am824_set_pcm_format(&efw->tx_stream, params_format(hw_params));

return 0;
}
Expand All @@ -270,7 +271,8 @@ static int pcm_playback_hw_params(struct snd_pcm_substream *substream,

if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN)
atomic_inc(&efw->playback_substreams);
amdtp_stream_set_pcm_format(&efw->rx_stream, params_format(hw_params));

amdtp_am824_set_pcm_format(&efw->rx_stream, params_format(hw_params));

return 0;
}
Expand Down
4 changes: 2 additions & 2 deletions sound/firewire/oxfw/oxfw-pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ static int pcm_capture_hw_params(struct snd_pcm_substream *substream,
mutex_unlock(&oxfw->mutex);
}

amdtp_stream_set_pcm_format(&oxfw->tx_stream, params_format(hw_params));
amdtp_am824_set_pcm_format(&oxfw->tx_stream, params_format(hw_params));

return 0;
}
Expand All @@ -265,7 +265,7 @@ static int pcm_playback_hw_params(struct snd_pcm_substream *substream,
mutex_unlock(&oxfw->mutex);
}

amdtp_stream_set_pcm_format(&oxfw->rx_stream, params_format(hw_params));
amdtp_am824_set_pcm_format(&oxfw->rx_stream, params_format(hw_params));

return 0;
}
Expand Down

0 comments on commit 85130cb

Please sign in to comment.