Skip to content

Commit

Permalink
powerpc: hard disable irqs in smp_send_stop loop
Browse files Browse the repository at this point in the history
The hard lockup watchdog can fire under local_irq_disable
on platforms with irq soft masking.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Nicholas Piggin authored and Michael Ellerman committed Apr 3, 2018
1 parent 6bed323 commit 855bfe0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions arch/powerpc/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,10 @@ static void stop_this_cpu(void *dummy)
/* Remove this CPU */
set_cpu_online(smp_processor_id(), false);

local_irq_disable();
hard_irq_disable();
spin_begin();
while (1)
;
spin_cpu_relax();
}

void smp_send_stop(void)
Expand Down

0 comments on commit 855bfe0

Please sign in to comment.