Skip to content

Commit

Permalink
firmware: Google VPD: Fix return value check in vpd_platform_init()
Browse files Browse the repository at this point in the history
In case of error, the function platform_device_register_simple()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Fixes: 049a59d ("firmware: Google VPD sysfs driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Wei Yongjun authored and Greg Kroah-Hartman committed Apr 26, 2017
1 parent f563dab commit 856c634
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/firmware/google/vpd.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,8 @@ static int __init vpd_platform_init(void)
struct platform_device *pdev;

pdev = platform_device_register_simple("vpd", -1, NULL, 0);
if (!pdev)
return -ENODEV;
if (IS_ERR(pdev))
return PTR_ERR(pdev);

vpd_kobj = kobject_create_and_add("vpd", firmware_kobj);
if (!vpd_kobj)
Expand Down

0 comments on commit 856c634

Please sign in to comment.