Skip to content

Commit

Permalink
drm/sun4i: dsi: Restrict DSI tcon clock divider
Browse files Browse the repository at this point in the history
The current code allows the TCON clock divider to have a range between 4
and 127 when feeding the DSI controller.

The only display supported so far had a display clock rate that ended up
using a divider of 4, but testing with other displays show that only 4
seems to be functional.

This also aligns with what Allwinner is doing in their BSP, so let's just
hardcode that we want a divider of 4 when using the DSI output.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/074e88ae472f5e0492e26939c74b44fb4125ffbd.1549896081.git-series.maxime.ripard@bootlin.com
  • Loading branch information
Maxime Ripard committed Feb 19, 2019
1 parent fd347df commit 85fb352
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/sun4i/sun4i_tcon.c
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ static void sun4i_tcon0_mode_set_cpu(struct sun4i_tcon *tcon,
u32 block_space, start_delay;
u32 tcon_div;

tcon->dclk_min_div = 4;
tcon->dclk_max_div = 127;
tcon->dclk_min_div = SUN6I_DSI_TCON_DIV;
tcon->dclk_max_div = SUN6I_DSI_TCON_DIV;

sun4i_tcon0_mode_set_common(tcon, mode);

Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
#include <drm/drm_encoder.h>
#include <drm/drm_mipi_dsi.h>

#define SUN6I_DSI_TCON_DIV 4

struct sun6i_dsi {
struct drm_connector connector;
struct drm_encoder encoder;
Expand Down

0 comments on commit 85fb352

Please sign in to comment.