Skip to content

Commit

Permalink
dm writecache: write at least 4k when committing
Browse files Browse the repository at this point in the history
SSDs perform badly with sub-4k writes (because they perfrorm
read-modify-write internally), so make sure writecache writes at least
4k when committing.

Fixes: 991bd8d ("dm writecache: commit just one block, not a full page")
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
Mikulas Patocka authored and Mike Snitzer committed Jun 21, 2021
1 parent ee55b92 commit 867de40
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/md/dm-writecache.c
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,11 @@ static void ssd_commit_superblock(struct dm_writecache *wc)

region.bdev = wc->ssd_dev->bdev;
region.sector = 0;
region.count = wc->block_size >> SECTOR_SHIFT;
region.count = max(4096U, wc->block_size) >> SECTOR_SHIFT;

if (unlikely(region.sector + region.count > wc->metadata_sectors))
region.count = wc->metadata_sectors - region.sector;

region.sector += wc->start_sector;

req.bi_op = REQ_OP_WRITE;
Expand Down

0 comments on commit 867de40

Please sign in to comment.