Skip to content

Commit

Permalink
perf test: Use TEST_FAIL in the TEST_ASSERT macros instead of -1
Browse files Browse the repository at this point in the history
Just to make things clearer, return TEST_FAIL (-1) instead of an open
coded -1.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/ZdepeMsjagbf1ufD@x1
  • Loading branch information
Arnaldo Carvalho de Melo authored and Namhyung Kim committed Feb 26, 2024
1 parent bae4d1f commit 8680999
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions tools/perf/tests/tests.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,17 @@

#include <stdbool.h>

enum {
TEST_OK = 0,
TEST_FAIL = -1,
TEST_SKIP = -2,
};

#define TEST_ASSERT_VAL(text, cond) \
do { \
if (!(cond)) { \
pr_debug("FAILED %s:%d %s\n", __FILE__, __LINE__, text); \
return -1; \
return TEST_FAIL; \
} \
} while (0)

Expand All @@ -17,16 +23,10 @@ do { \
if (val != expected) { \
pr_debug("FAILED %s:%d %s (%d != %d)\n", \
__FILE__, __LINE__, text, val, expected); \
return -1; \
return TEST_FAIL; \
} \
} while (0)

enum {
TEST_OK = 0,
TEST_FAIL = -1,
TEST_SKIP = -2,
};

struct test_suite;

typedef int (*test_fnptr)(struct test_suite *, int);
Expand Down

0 comments on commit 8680999

Please sign in to comment.