Skip to content

Commit

Permalink
ACPI: replace strlen("string") with sizeof("string") -1
Browse files Browse the repository at this point in the history
...both give the number of chars in the string
without the '\0', as strncmp() wants,
but sizeof() is compile-time.

Reported-by: Alan Stern <stern@rowland.harvard.edu>
Cc: Pavel Vasilyev <pavel@pavlinux.ru>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Len Brown committed Jul 27, 2012
1 parent a5ca734 commit 869639f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/acpi/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@ static int param_set_trace_state(const char *val, struct kernel_param *kp)
{
int result = 0;

if (!strncmp(val, "enable", strlen("enable"))) {
if (!strncmp(val, "enable", sizeof("enable") - 1)) {
result = acpi_debug_trace(trace_method_name, trace_debug_level,
trace_debug_layer, 0);
if (result)
result = -EBUSY;
goto exit;
}

if (!strncmp(val, "disable", strlen("disable"))) {
if (!strncmp(val, "disable", sizeof("disable") - 1)) {
int name = 0;
result = acpi_debug_trace((char *)&name, trace_debug_level,
trace_debug_layer, 0);
Expand Down

0 comments on commit 869639f

Please sign in to comment.