Skip to content

Commit

Permalink
driver core: Add class_attr_string for simple read-only string
Browse files Browse the repository at this point in the history
Several drivers just export a static string as class attributes.

Use the new extensible attribute support to define a simple
CLASS_ATTR_STRING() macro for this.

This will allow to remove code from drivers in followon patches.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Andi Kleen authored and Greg Kroah-Hartman committed Mar 8, 2010
1 parent 28812fe commit 869dfc8
Showing 2 changed files with 27 additions and 0 deletions.
10 changes: 10 additions & 0 deletions drivers/base/class.c
Original file line number Diff line number Diff line change
@@ -490,6 +490,16 @@ void class_interface_unregister(struct class_interface *class_intf)
class_put(parent);
}

ssize_t show_class_attr_string(struct class *class, struct class_attribute *attr,
char *buf)
{
struct class_attribute_string *cs;
cs = container_of(attr, struct class_attribute_string, attr);
return snprintf(buf, PAGE_SIZE, "%s\n", cs->str);
}

EXPORT_SYMBOL_GPL(show_class_attr_string);

struct class_compat {
struct kobject *kobj;
};
17 changes: 17 additions & 0 deletions include/linux/device.h
Original file line number Diff line number Diff line change
@@ -265,6 +265,23 @@ extern int __must_check class_create_file(struct class *class,
extern void class_remove_file(struct class *class,
const struct class_attribute *attr);

/* Simple class attribute that is just a static string */

struct class_attribute_string {
struct class_attribute attr;
char *str;
};

/* Currently read-only only */
#define _CLASS_ATTR_STRING(_name, _mode, _str) \
{ __ATTR(_name, _mode, show_class_attr_string, NULL), _str }
#define CLASS_ATTR_STRING(_name, _mode, _str) \
struct class_attribute_string class_attr_##_name = \
_CLASS_ATTR_STRING(_name, _mode, _str)

extern ssize_t show_class_attr_string(struct class *class, struct class_attribute *attr,
char *buf);

struct class_interface {
struct list_head node;
struct class *class;

0 comments on commit 869dfc8

Please sign in to comment.