Skip to content

Commit

Permalink
mmc: sdhci-of-arasan: Obviously always return success in remove callback
Browse files Browse the repository at this point in the history
sdhci_pltfm_unregister() returns 0 unconditionally and returning an
error in a platform remove callback isn't very sensible. (The only
effect of the latter is that the device core emits a generic warning and
then removes the device anyhow.)

So return 0 unconditionally to make it obvious there is no error
forwarded to the upper layers.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20220610211257.102071-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Uwe Kleine-König authored and Ulf Hansson committed Jul 12, 2022
1 parent 397605c commit 869f987
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/mmc/host/sdhci-of-arasan.c
Original file line number Diff line number Diff line change
Expand Up @@ -1733,7 +1733,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)

static int sdhci_arasan_remove(struct platform_device *pdev)
{
int ret;
struct sdhci_host *host = platform_get_drvdata(pdev);
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host);
Expand All @@ -1747,11 +1746,11 @@ static int sdhci_arasan_remove(struct platform_device *pdev)

sdhci_arasan_unregister_sdclk(&pdev->dev);

ret = sdhci_pltfm_unregister(pdev);
sdhci_pltfm_unregister(pdev);

clk_disable_unprepare(clk_ahb);

return ret;
return 0;
}

static struct platform_driver sdhci_arasan_driver = {
Expand Down

0 comments on commit 869f987

Please sign in to comment.