Skip to content

Commit

Permalink
sparc64: Flush TLB before releasing pages.
Browse files Browse the repository at this point in the history
tlb_flush_mmu() needs to flush pending TLB entries before
processing the mmu_gather ->pages list.

Noticed by Benjamin Herrenschmidt.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Mar 26, 2009
1 parent 8e0ee43 commit 86ee79c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/sparc/include/asm/tlb_64.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ static inline struct mmu_gather *tlb_gather_mmu(struct mm_struct *mm, unsigned i

static inline void tlb_flush_mmu(struct mmu_gather *mp)
{
if (!mp->fullmm)
flush_tlb_pending();
if (mp->need_flush) {
free_pages_and_swap_cache(mp->pages, mp->pages_nr);
mp->pages_nr = 0;
Expand All @@ -78,8 +80,6 @@ static inline void tlb_finish_mmu(struct mmu_gather *mp, unsigned long start, un

if (mp->fullmm)
mp->fullmm = 0;
else
flush_tlb_pending();

/* keep the page table cache within bounds */
check_pgt_cache();
Expand Down

0 comments on commit 86ee79c

Please sign in to comment.