Skip to content

Commit

Permalink
debugfs: move to new strtobool
Browse files Browse the repository at this point in the history
No functional changes requires that we eat errors from strtobool.
If people want to not do this, then it should be fixed at a later date.

V2: Simplification suggested by Rusty Russell removes the need for
additional variable ret.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jonathan Cameron authored and Greg Kroah-Hartman committed Apr 25, 2011
1 parent ad58671 commit 8705b48
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions fs/debugfs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -429,25 +429,16 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf,
{
char buf[32];
int buf_size;
bool bv;
u32 *val = file->private_data;

buf_size = min(count, (sizeof(buf)-1));
if (copy_from_user(buf, user_buf, buf_size))
return -EFAULT;

switch (buf[0]) {
case 'y':
case 'Y':
case '1':
*val = 1;
break;
case 'n':
case 'N':
case '0':
*val = 0;
break;
}

if (strtobool(buf, &bv) == 0)
*val = bv;

return count;
}

Expand Down

0 comments on commit 8705b48

Please sign in to comment.