Skip to content

Commit

Permalink
hwrng: octeon - remove incorrect __exit markups
Browse files Browse the repository at this point in the history
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Dmitry Torokhov authored and Herbert Xu committed Mar 11, 2015
1 parent 1ee9b5e commit 87094a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/char/hw_random/octeon-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ static int octeon_rng_probe(struct platform_device *pdev)
return 0;
}

static int __exit octeon_rng_remove(struct platform_device *pdev)
static int octeon_rng_remove(struct platform_device *pdev)
{
struct hwrng *rng = platform_get_drvdata(pdev);

Expand All @@ -119,7 +119,7 @@ static struct platform_driver octeon_rng_driver = {
.name = "octeon_rng",
},
.probe = octeon_rng_probe,
.remove = __exit_p(octeon_rng_remove),
.remove = octeon_rng_remove,
};

module_platform_driver(octeon_rng_driver);
Expand Down

0 comments on commit 87094a0

Please sign in to comment.