Skip to content

Commit

Permalink
i386, dumpstack: unify die()
Browse files Browse the repository at this point in the history
Make i386's die() equal to x86_64's version.

Whitespace-only changes on x86_64, to make it equal to i386's
version. (user_mode and user_mode_vm are equal on x86_64.)

Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Alexander van Heukelum authored and Ingo Molnar committed Oct 22, 2008
1 parent e06ca43 commit 871d377
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
10 changes: 3 additions & 7 deletions arch/x86/kernel/dumpstack_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,15 +378,11 @@ void die(const char *str, struct pt_regs *regs, long err)
unsigned long flags = oops_begin();
int sig = SIGSEGV;

if (die_nest_count < 3) {
if (!user_mode_vm(regs))
report_bug(regs->ip, regs);

if (__die(str, regs, err))
sig = 0;
} else {
printk(KERN_EMERG "Recursive die() failure, output suppressed\n");
}

if (__die(str, regs, err))
sig = 0;
oops_end(flags, regs, sig);
}

Expand Down
6 changes: 5 additions & 1 deletion arch/x86/kernel/dumpstack_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -506,12 +506,16 @@ int __kprobes __die(const char *str, struct pt_regs *regs, long err)
return 0;
}

/*
* This is gone through when something in the kernel has done something bad
* and is about to be terminated:
*/
void die(const char *str, struct pt_regs *regs, long err)
{
unsigned long flags = oops_begin();
int sig = SIGSEGV;

if (!user_mode(regs))
if (!user_mode_vm(regs))
report_bug(regs->ip, regs);

if (__die(str, regs, err))
Expand Down

0 comments on commit 871d377

Please sign in to comment.