Skip to content

Commit

Permalink
spi: davinci: Initialize dspi->done before any possible use of it
Browse files Browse the repository at this point in the history
On SOC with multiple cpu (like omal l138) it is possible that spi
periferic is already initialized when this module is loaded and so
it is possible to recieve interrupt when the modules is not fully
initialized.

this patch initialize dspi->done before refister the interrupt
handler that use it

Signed-off-by: Michele Dionisio <michele.dionisio@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Michele Dionisio authored and Mark Brown committed Dec 12, 2017
1 parent 4fbd8d1 commit 87248dc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/spi/spi-davinci.c
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,8 @@ static int davinci_spi_probe(struct platform_device *pdev)
goto free_master;
}

init_completion(&dspi->done);

ret = platform_get_irq(pdev, 0);
if (ret == 0)
ret = -EINVAL;
Expand Down Expand Up @@ -1021,8 +1023,6 @@ static int davinci_spi_probe(struct platform_device *pdev)
dspi->get_rx = davinci_spi_rx_buf_u8;
dspi->get_tx = davinci_spi_tx_buf_u8;

init_completion(&dspi->done);

/* Reset In/OUT SPI module */
iowrite32(0, dspi->base + SPIGCR0);
udelay(100);
Expand Down

0 comments on commit 87248dc

Please sign in to comment.