Skip to content

Commit

Permalink
[media] omap3isp: Rename the variable names in description
Browse files Browse the repository at this point in the history
This patch renames the variable in the description to match it
appropriately to function definition.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
  • Loading branch information
Lad, Prabhakar authored and Mauro Carvalho Chehab committed Mar 5, 2014
1 parent fdf7bbe commit 872aba5
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 21 deletions.
12 changes: 6 additions & 6 deletions drivers/media/platform/omap3isp/isp.h
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ void omap3isp_unregister_entities(struct platform_device *pdev);

/*
* isp_reg_readl - Read value of an OMAP3 ISP register
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
* @isp_mmio_range: Range to which the register offset refers to.
* @reg_offset: Register offset to read from.
*
Expand All @@ -280,7 +280,7 @@ u32 isp_reg_readl(struct isp_device *isp, enum isp_mem_resources isp_mmio_range,

/*
* isp_reg_writel - Write value to an OMAP3 ISP register
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
* @reg_value: 32 bit value to write to the register.
* @isp_mmio_range: Range to which the register offset refers to.
* @reg_offset: Register offset to write into.
Expand All @@ -293,8 +293,8 @@ void isp_reg_writel(struct isp_device *isp, u32 reg_value,
}

/*
* isp_reg_and - Clear individual bits in an OMAP3 ISP register
* @dev: Device pointer specific to the OMAP3 ISP.
* isp_reg_clr - Clear individual bits in an OMAP3 ISP register
* @isp: Device pointer specific to the OMAP3 ISP.
* @mmio_range: Range to which the register offset refers to.
* @reg: Register offset to work on.
* @clr_bits: 32 bit value which would be cleared in the register.
Expand All @@ -310,7 +310,7 @@ void isp_reg_clr(struct isp_device *isp, enum isp_mem_resources mmio_range,

/*
* isp_reg_set - Set individual bits in an OMAP3 ISP register
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
* @mmio_range: Range to which the register offset refers to.
* @reg: Register offset to work on.
* @set_bits: 32 bit value which would be set in the register.
Expand All @@ -326,7 +326,7 @@ void isp_reg_set(struct isp_device *isp, enum isp_mem_resources mmio_range,

/*
* isp_reg_clr_set - Clear and set invidial bits in an OMAP3 ISP register
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
* @mmio_range: Range to which the register offset refers to.
* @reg: Register offset to work on.
* @clr_bits: 32 bit value which would be cleared in the register.
Expand Down
8 changes: 4 additions & 4 deletions drivers/media/platform/omap3isp/ispccdc.c
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ static void ccdc_config_imgattr(struct isp_ccdc_device *ccdc, u32 colptn)
/*
* ccdc_config - Set CCDC configuration from userspace
* @ccdc: Pointer to ISP CCDC device.
* @userspace_add: Structure containing CCDC configuration sent from userspace.
* @ccdc_struct: Structure containing CCDC configuration sent from userspace.
*
* Returns 0 if successful, -EINVAL if the pointer to the configuration
* structure is null, or the copy_from_user function fails to copy user space
Expand Down Expand Up @@ -793,7 +793,7 @@ static void ccdc_apply_controls(struct isp_ccdc_device *ccdc)

/*
* omap3isp_ccdc_restore_context - Restore values of the CCDC module registers
* @dev: Pointer to ISP device
* @isp: Pointer to ISP device
*/
void omap3isp_ccdc_restore_context(struct isp_device *isp)
{
Expand Down Expand Up @@ -2525,7 +2525,7 @@ static int ccdc_init_entities(struct isp_ccdc_device *ccdc)

/*
* omap3isp_ccdc_init - CCDC module initialization.
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
*
* TODO: Get the initialisation values from platform data.
*
Expand Down Expand Up @@ -2564,7 +2564,7 @@ int omap3isp_ccdc_init(struct isp_device *isp)

/*
* omap3isp_ccdc_cleanup - CCDC module cleanup.
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
*/
void omap3isp_ccdc_cleanup(struct isp_device *isp)
{
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/platform/omap3isp/ispccp2.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ static void ccp2_mem_enable(struct isp_ccp2_device *ccp2, u8 enable)
/*
* ccp2_phyif_config - Initialize CCP2 phy interface config
* @ccp2: Pointer to ISP CCP2 device
* @config: CCP2 platform data
* @pdata: CCP2 platform data
*
* Configure the CCP2 physical interface module from platform data.
*
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/platform/omap3isp/isphist.c
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ static u32 hist_get_buf_size(struct omap3isp_hist_config *conf)

/*
* hist_validate_params - Helper function to check user given params.
* @user_cfg: Pointer to user configuration structure.
* @new_conf: Pointer to user configuration structure.
*
* Returns 0 on success configuration.
*/
Expand Down
9 changes: 5 additions & 4 deletions drivers/media/platform/omap3isp/isppreview.c
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,8 @@ static void preview_setup_hw(struct isp_prev_device *prev, u32 update,

/*
* preview_config_ycpos - Configure byte layout of YUV image.
* @mode: Indicates the required byte layout.
* @prev: pointer to previewer private structure
* @pixelcode: pixel code
*/
static void
preview_config_ycpos(struct isp_prev_device *prev,
Expand Down Expand Up @@ -1373,7 +1374,7 @@ static void preview_init_params(struct isp_prev_device *prev)

/*
* preview_max_out_width - Handle previewer hardware output limitations
* @isp_revision : ISP revision
* @prev: pointer to previewer private structure
* returns maximum width output for current isp revision
*/
static unsigned int preview_max_out_width(struct isp_prev_device *prev)
Expand Down Expand Up @@ -1619,7 +1620,7 @@ static const struct v4l2_ctrl_ops preview_ctrl_ops = {

/*
* preview_ioctl - Handle preview module private ioctl's
* @prev: pointer to preview context structure
* @sd: pointer to v4l2 subdev structure
* @cmd: configuration command
* @arg: configuration argument
* return -EINVAL or zero on success
Expand Down Expand Up @@ -2350,7 +2351,7 @@ static int preview_init_entities(struct isp_prev_device *prev)

/*
* omap3isp_preview_init - Previewer initialization.
* @dev : Pointer to ISP device
* @isp : Pointer to ISP device
* return -ENOMEM or zero on success
*/
int omap3isp_preview_init(struct isp_device *isp)
Expand Down
6 changes: 3 additions & 3 deletions drivers/media/platform/omap3isp/ispresizer.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ static void resizer_set_bilinear(struct isp_res_device *res,
/*
* resizer_set_ycpos - Luminance and chrominance order
* @res: Device context.
* @order: order type.
* @pixelcode: pixel code.
*/
static void resizer_set_ycpos(struct isp_res_device *res,
enum v4l2_mbus_pixelcode pixelcode)
Expand Down Expand Up @@ -918,8 +918,8 @@ static void resizer_calc_ratios(struct isp_res_device *res,
/*
* resizer_set_crop_params - Setup hardware with cropping parameters
* @res : resizer private structure
* @crop_rect : current crop rectangle
* @ratio : resizer ratios
* @input : format on sink pad
* @output : format on source pad
* return none
*/
static void resizer_set_crop_params(struct isp_res_device *res,
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/platform/omap3isp/ispvideo.c
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ isp_video_check_format(struct isp_video *video, struct isp_video_fh *vfh)

/*
* ispmmu_vmap - Wrapper for Virtual memory mapping of a scatter gather list
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
* @sglist: Pointer to source Scatter gather list to allocate.
* @sglen: Number of elements of the scatter-gatter list.
*
Expand Down Expand Up @@ -363,7 +363,7 @@ ispmmu_vmap(struct isp_device *isp, const struct scatterlist *sglist, int sglen)

/*
* ispmmu_vunmap - Unmap a device address from the ISP MMU
* @dev: Device pointer specific to the OMAP3 ISP.
* @isp: Device pointer specific to the OMAP3 ISP.
* @da: Device address generated from a ispmmu_vmap call.
*/
static void ispmmu_vunmap(struct isp_device *isp, dma_addr_t da)
Expand Down

0 comments on commit 872aba5

Please sign in to comment.