Skip to content

Commit

Permalink
sit: set rtnl_link_ops before calling register_netdevice
Browse files Browse the repository at this point in the history
When creating a SIT tunnel with ip tunnel, rtnl_link_ops is not set before
ipip6_tunnel_create is called. When register_netdevice is called, there is
no linkinfo attribute in the NEWLINK message because of that.

Setting rtnl_link_ops before calling register_netdevice fixes that.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Thadeu Lima de Souza Cascardo authored and David S. Miller committed Jan 25, 2016
1 parent 05f3b50 commit 87e5739
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/ipv6/sit.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,14 @@ static int ipip6_tunnel_create(struct net_device *dev)
if ((__force u16)t->parms.i_flags & SIT_ISATAP)
dev->priv_flags |= IFF_ISATAP;

dev->rtnl_link_ops = &sit_link_ops;

err = register_netdevice(dev);
if (err < 0)
goto out;

ipip6_tunnel_clone_6rd(dev, sitn);

dev->rtnl_link_ops = &sit_link_ops;

dev_hold(dev);

ipip6_tunnel_link(sitn, t);
Expand Down

0 comments on commit 87e5739

Please sign in to comment.