Skip to content

Commit

Permalink
perf hists: Collapse expanded callchains after filter is applied
Browse files Browse the repository at this point in the history
When a filter is applied a hist entry checks whether its callchain was
folded and account it to the output stat.  But this is rather hacky
and only TUI-specific.  Simply fold the callchains for the entry looks
like a simpler and more generic solution IMHO.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1398327843-31845-6-git-send-email-namhyung@kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
  • Loading branch information
Namhyung Kim authored and Jiri Olsa committed Apr 24, 2014
1 parent 9283ba9 commit 87e90f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/perf/util/hist.c
Original file line number Diff line number Diff line change
Expand Up @@ -716,8 +716,8 @@ static void hists__remove_entry_filter(struct hists *hists, struct hist_entry *h
if (h->filtered)
return;

if (h->ms.unfolded)
hists->nr_non_filtered_entries += h->nr_rows;
/* force fold unfiltered entry for simplicity */
h->ms.unfolded = false;
h->row_offset = 0;

hists->stats.nr_non_filtered_samples += h->stat.nr_events;
Expand Down

0 comments on commit 87e90f4

Please sign in to comment.