Skip to content

Commit

Permalink
hwrng: cavium - Use per device name to allow for multiple devices.
Browse files Browse the repository at this point in the history
Systems containing the Cavium HW RNG may have one device per NUMA
node.  A typical configuration is a 2-node NUMA system, which results
in 2 RNG devices.  The hwrng subsystem refuses (and rightly so) to
register more than one device with he same name, so we get failure
messages on these systems.

Make the hwrng name unique by including the underlying device name.
Also remove spaces from the name to make it possible to switch devices
via the sysfs knobs.

Signed-off-by: David Daney <david.daney@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
David Daney authored and Herbert Xu committed Feb 11, 2017
1 parent 4c147bc commit 87f3d08
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/char/hw_random/cavium-rng-vf.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ static int cavium_rng_probe_vf(struct pci_dev *pdev,
return -ENOMEM;
}

rng->ops.name = "cavium rng";
rng->ops.name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
"cavium-rng-%s", dev_name(&pdev->dev));
if (!rng->ops.name)
return -ENOMEM;

rng->ops.read = cavium_rng_read;
rng->ops.quality = 1000;

Expand Down

0 comments on commit 87f3d08

Please sign in to comment.