Skip to content

Commit

Permalink
rtc: twl: remove unnecessary messages
Browse files Browse the repository at this point in the history
The RTC core already prints a message when the RTC is registered and when
registering fails, it is not necessary to have more in the driver.

Link: https://lore.kernel.org/r/20230827221643.544259-2-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  • Loading branch information
Alexandre Belloni committed Sep 5, 2023
1 parent 94ec1f0 commit 8805bac
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/rtc/rtc-twl.c
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,6 @@ static int twl_rtc_probe(struct platform_device *pdev)
REG_INT_MSK_STS_A);
}

dev_info(&pdev->dev, "Enabling TWL-RTC\n");
ret = twl_rtc_write_u8(twl_rtc, BIT_RTC_CTRL_REG_STOP_RTC_M,
REG_RTC_CTRL_REG);
if (ret < 0)
Expand All @@ -577,11 +576,8 @@ static int twl_rtc_probe(struct platform_device *pdev)

twl_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
&twl_rtc_ops, THIS_MODULE);
if (IS_ERR(twl_rtc->rtc)) {
dev_err(&pdev->dev, "can't register RTC device, err %ld\n",
PTR_ERR(twl_rtc->rtc));
if (IS_ERR(twl_rtc->rtc))
return PTR_ERR(twl_rtc->rtc);
}

ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
twl_rtc_interrupt,
Expand Down

0 comments on commit 8805bac

Please sign in to comment.