Skip to content

Commit

Permalink
tracing: remove duplicate null-pointer check in skb tracepoint
Browse files Browse the repository at this point in the history
The check for NULL skb in the kfree_skb trace event is a duplicate from the
check already done in its only caller, kfree_skb(). Remove this duplicate check.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
LKML-Reference: <20110106175319.GA30610@Krystal>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: David S. Miller <davem@davemloft.net>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Zhaolei <zhaolei@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Mathieu Desnoyers authored and Steven Rostedt committed Jan 8, 2011
1 parent ec6e7c3 commit 881fe4b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions include/trace/events/skb.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,

TP_fast_assign(
__entry->skbaddr = skb;
if (skb) {
__entry->protocol = ntohs(skb->protocol);
}
__entry->protocol = ntohs(skb->protocol);
__entry->location = location;
),

Expand Down

0 comments on commit 881fe4b

Please sign in to comment.