Skip to content

Commit

Permalink
xen-pciback: Cleanup up pcistub_put_pci_dev
Browse files Browse the repository at this point in the history
We are using 'psdev->dev','found_psdev->dev', and 'dev' at the
same time - and they all point to the same structure.

To keep it straight lets just use one - 'dev'.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
  • Loading branch information
Konrad Rzeszutek Wilk committed May 23, 2014
1 parent f59c514 commit 8899035
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/xen/xen-pciback/pci_stub.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,16 +272,16 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
* and want to inhibit the user from fiddling with 'reset'
*/
pci_reset_function(dev);
pci_restore_state(psdev->dev);
pci_restore_state(dev);

/* This disables the device. */
xen_pcibk_reset_device(found_psdev->dev);
xen_pcibk_reset_device(dev);

/* And cleanup up our emulated fields. */
xen_pcibk_config_free_dyn_fields(found_psdev->dev);
xen_pcibk_config_reset_dev(found_psdev->dev);
xen_pcibk_config_free_dyn_fields(dev);
xen_pcibk_config_reset_dev(dev);

xen_unregister_device_domain_owner(found_psdev->dev);
xen_unregister_device_domain_owner(dev);

spin_lock_irqsave(&found_psdev->lock, flags);
found_psdev->pdev = NULL;
Expand Down

0 comments on commit 8899035

Please sign in to comment.