Skip to content

Commit

Permalink
futex: remove the pointer math from double_unlock_hb, fix
Browse files Browse the repository at this point in the history
Impact: fix double unlock crash

Thomas Gleixner noticed that the simplified double_unlock_hb()
became ... too unsophisticated: in the hb1 == hb2 case it will
do a double unlock.

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Darren Hart <dvhltc@us.ibm.com>
LKML-Reference: <20090312221118.11146.68610.stgit@Aeon>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Mar 13, 2009
1 parent f061d35 commit 88f502f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion kernel/futex.c
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,8 @@ static inline void
double_unlock_hb(struct futex_hash_bucket *hb1, struct futex_hash_bucket *hb2)
{
spin_unlock(&hb1->lock);
spin_unlock(&hb2->lock);
if (hb1 != hb2)
spin_unlock(&hb2->lock);
}

/*
Expand Down

0 comments on commit 88f502f

Please sign in to comment.