Skip to content

Commit

Permalink
dm: simplify the single bio fast path in __send_duplicate_bios
Browse files Browse the repository at this point in the history
Most targets just need a single flush bio.  Open code that case in
__send_duplicate_bios without the need to add the bio to a list.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Link: https://lore.kernel.org/r/20220202160109.108149-9-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Feb 4, 2022
1 parent 1d1068c commit 891fced
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions drivers/md/dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1241,15 +1241,6 @@ static void alloc_multiple_bios(struct bio_list *blist, struct clone_info *ci,
struct bio *bio;
int try;

if (!num_bios)
return;

if (num_bios == 1) {
bio = alloc_tio(ci, ti, 0, len, GFP_NOIO);
bio_list_add(blist, bio);
return;
}

for (try = 0; try < 2; try++) {
int bio_nr;

Expand Down Expand Up @@ -1279,12 +1270,23 @@ static void __send_duplicate_bios(struct clone_info *ci, struct dm_target *ti,
struct bio_list blist = BIO_EMPTY_LIST;
struct bio *clone;

alloc_multiple_bios(&blist, ci, ti, num_bios, len);

while ((clone = bio_list_pop(&blist))) {
switch (num_bios) {
case 0:
break;
case 1:
clone = alloc_tio(ci, ti, 0, len, GFP_NOIO);
if (len)
bio_setup_sector(clone, ci->sector, *len);
__map_bio(clone);
break;
default:
alloc_multiple_bios(&blist, ci, ti, num_bios, len);
while ((clone = bio_list_pop(&blist))) {
if (len)
bio_setup_sector(clone, ci->sector, *len);
__map_bio(clone);
}
break;
}
}

Expand Down

0 comments on commit 891fced

Please sign in to comment.