Skip to content

Commit

Permalink
staging/vboxvideo: Another FIXME item
Browse files Browse the repository at this point in the history
Found while grepping around.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190221155951.19855-1-daniel.vetter@ffwll.ch
  • Loading branch information
Daniel Vetter authored and Hans de Goede committed Mar 11, 2019
1 parent a34ced4 commit 893ded3
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/staging/vboxvideo/vbox_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox)

validate_or_set_position_hints(vbox);
drm_modeset_lock_all(dev);
/*
* FIXME: this needs to use drm_connector_list_iter and some real
* locking for the actual data it changes, not the deprecated
* drm_modeset_lock_all() shotgun approach.
*/
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
vbox_conn = to_vbox_connector(connector);

Expand Down

0 comments on commit 893ded3

Please sign in to comment.