Skip to content

Commit

Permalink
clk: k210: remove an implicit 64-bit division
Browse files Browse the repository at this point in the history
The K210 clock driver depends on SOC_CANAAN, which is only selectable
when !MMU on RISC-V. !MMU is not possible on 32-bit yet, but patches
have been sent for its enabling. The kernel test robot reported this
implicit 64-bit division there.

Replace the implicit division with an explicit one.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/linux-riscv/202301201538.zNlqgE4L-lkp@intel.com/
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
Link: https://lore.kernel.org/r/20230301002657.352637-2-Mr.Bossman075@gmail.com
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Conor Dooley authored and Stephen Boyd committed Mar 6, 2023
1 parent 2624387 commit 89dc65a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clk/clk-k210.c
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ static unsigned long k210_pll_get_rate(struct clk_hw *hw,
f = FIELD_GET(K210_PLL_CLKF, reg) + 1;
od = FIELD_GET(K210_PLL_CLKOD, reg) + 1;

return (u64)parent_rate * f / (r * od);
return div_u64((u64)parent_rate * f, r * od);
}

static const struct clk_ops k210_pll_ops = {
Expand Down

0 comments on commit 89dc65a

Please sign in to comment.