Skip to content

Commit

Permalink
efivarfs: Remove unused internal struct members
Browse files Browse the repository at this point in the history
The structure was moved to the efivarfs internals in commit 2d82e62
("efi: vars: Move efivar caching layer into efivarfs") after previously
being used as the data ABI for efivars until its removal in commit
0f5b2c6 ("efi: vars: Remove deprecated 'efivars' sysfs interface").

As efivarfs only uses the structure for the variable name caching layer,
the data-related members were never in use. Remove them to avoid
implying that efivarfs is bound by the same restrictions that efivars
once had. While at it, remove the packed attribute, since we no longer
have to guarantee a stable layout.

Signed-off-by: Tim Schumacher <timschumi@gmx.de>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
  • Loading branch information
Tim Schumacher authored and Ard Biesheuvel committed Apr 13, 2024
1 parent 5b62518 commit 89ea21d
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/efivarfs/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,8 @@ struct efivarfs_fs_info {
struct efi_variable {
efi_char16_t VariableName[EFI_VAR_NAME_LEN/sizeof(efi_char16_t)];
efi_guid_t VendorGuid;
unsigned long DataSize;
__u8 Data[1024];
efi_status_t Status;
__u32 Attributes;
} __attribute__((packed));
};

struct efivar_entry {
struct efi_variable var;
Expand Down

0 comments on commit 89ea21d

Please sign in to comment.