Skip to content

Commit

Permalink
x86/headers: Replace __ASSEMBLY__ with __ASSEMBLER__ in UAPI headers
Browse files Browse the repository at this point in the history
__ASSEMBLY__ is only defined by the Makefile of the kernel, so
this is not really useful for UAPI headers (unless the userspace
Makefile defines it, too). Let's switch to __ASSEMBLER__ which
gets set automatically by the compiler when compiling assembly
code.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Brian Gerst <brgerst@gmail.com>
Link: https://lore.kernel.org/r/20250310104256.123527-1-thuth@redhat.com
  • Loading branch information
Thomas Huth authored and Ingo Molnar committed Mar 19, 2025
1 parent faa6f77 commit 8a141be
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 19 deletions.
4 changes: 2 additions & 2 deletions arch/x86/include/uapi/asm/bootparam.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#define XLF_5LEVEL_ENABLED (1<<6)
#define XLF_MEM_ENCRYPTION (1<<7)

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__

#include <linux/types.h>
#include <linux/screen_info.h>
Expand Down Expand Up @@ -210,6 +210,6 @@ enum x86_hardware_subarch {
X86_NR_SUBARCHS,
};

#endif /* __ASSEMBLY__ */
#endif /* __ASSEMBLER__ */

#endif /* _ASM_X86_BOOTPARAM_H */
4 changes: 2 additions & 2 deletions arch/x86/include/uapi/asm/e820.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
*/
#define E820_RESERVED_KERN 128

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__
#include <linux/types.h>
struct e820entry {
__u64 addr; /* start of memory segment */
Expand All @@ -76,7 +76,7 @@ struct e820map {
#define BIOS_ROM_BASE 0xffe00000
#define BIOS_ROM_END 0xffffffff

#endif /* __ASSEMBLY__ */
#endif /* __ASSEMBLER__ */


#endif /* _UAPI_ASM_X86_E820_H */
4 changes: 2 additions & 2 deletions arch/x86/include/uapi/asm/ldt.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/* The size of each LDT entry. */
#define LDT_ENTRY_SIZE 8

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__
/*
* Note on 64bit base and limit is ignored and you cannot set DS/ES/CS
* not to the default values if you still want to do syscalls. This
Expand Down Expand Up @@ -44,5 +44,5 @@ struct user_desc {
#define MODIFY_LDT_CONTENTS_STACK 1
#define MODIFY_LDT_CONTENTS_CODE 2

#endif /* !__ASSEMBLY__ */
#endif /* !__ASSEMBLER__ */
#endif /* _ASM_X86_LDT_H */
4 changes: 2 additions & 2 deletions arch/x86/include/uapi/asm/msr.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
#ifndef _UAPI_ASM_X86_MSR_H
#define _UAPI_ASM_X86_MSR_H

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__

#include <linux/types.h>
#include <linux/ioctl.h>

#define X86_IOC_RDMSR_REGS _IOWR('c', 0xA0, __u32[8])
#define X86_IOC_WRMSR_REGS _IOWR('c', 0xA1, __u32[8])

#endif /* __ASSEMBLY__ */
#endif /* __ASSEMBLER__ */
#endif /* _UAPI_ASM_X86_MSR_H */
6 changes: 3 additions & 3 deletions arch/x86/include/uapi/asm/ptrace-abi.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

#else /* __i386__ */

#if defined(__ASSEMBLY__) || defined(__FRAME_OFFSETS)
#if defined(__ASSEMBLER__) || defined(__FRAME_OFFSETS)
/*
* C ABI says these regs are callee-preserved. They aren't saved on kernel entry
* unless syscall needs a complete, fully filled "struct pt_regs".
Expand Down Expand Up @@ -57,7 +57,7 @@
#define EFLAGS 144
#define RSP 152
#define SS 160
#endif /* __ASSEMBLY__ */
#endif /* __ASSEMBLER__ */

/* top of stack page */
#define FRAME_SIZE 168
Expand Down Expand Up @@ -87,7 +87,7 @@

#define PTRACE_SINGLEBLOCK 33 /* resume execution until next branch */

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__
#include <linux/types.h>
#endif

Expand Down
4 changes: 2 additions & 2 deletions arch/x86/include/uapi/asm/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include <asm/processor-flags.h>


#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__

#ifdef __i386__
/* this struct defines the way the registers are stored on the
Expand Down Expand Up @@ -81,6 +81,6 @@ struct pt_regs {



#endif /* !__ASSEMBLY__ */
#endif /* !__ASSEMBLER__ */

#endif /* _UAPI_ASM_X86_PTRACE_H */
4 changes: 2 additions & 2 deletions arch/x86/include/uapi/asm/setup_data.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#define SETUP_INDIRECT (1<<31)
#define SETUP_TYPE_MAX (SETUP_ENUM_MAX | SETUP_INDIRECT)

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__

#include <linux/types.h>

Expand Down Expand Up @@ -78,6 +78,6 @@ struct ima_setup_data {
__u64 size;
} __attribute__((packed));

#endif /* __ASSEMBLY__ */
#endif /* __ASSEMBLER__ */

#endif /* _UAPI_ASM_X86_SETUP_DATA_H */
8 changes: 4 additions & 4 deletions arch/x86/include/uapi/asm/signal.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#ifndef _UAPI_ASM_X86_SIGNAL_H
#define _UAPI_ASM_X86_SIGNAL_H

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__
#include <linux/types.h>
#include <linux/compiler.h>

Expand All @@ -16,7 +16,7 @@ struct siginfo;
typedef unsigned long sigset_t;

#endif /* __KERNEL__ */
#endif /* __ASSEMBLY__ */
#endif /* __ASSEMBLER__ */


#define SIGHUP 1
Expand Down Expand Up @@ -68,7 +68,7 @@ typedef unsigned long sigset_t;

#include <asm-generic/signal-defs.h>

#ifndef __ASSEMBLY__
#ifndef __ASSEMBLER__


# ifndef __KERNEL__
Expand Down Expand Up @@ -106,6 +106,6 @@ typedef struct sigaltstack {
__kernel_size_t ss_size;
} stack_t;

#endif /* __ASSEMBLY__ */
#endif /* __ASSEMBLER__ */

#endif /* _UAPI_ASM_X86_SIGNAL_H */

0 comments on commit 8a141be

Please sign in to comment.