Skip to content

Commit

Permalink
powerpc: add __NR_syscalls along with NR_syscalls
Browse files Browse the repository at this point in the history
NR_syscalls macro holds the number of system call exist
in powerpc architecture. We have to change the value of
NR_syscalls, if we add or delete a system call.

One of the patch in this patch series has a script which
will generate a uapi header based on syscall.tbl file.
The syscall.tbl file contains the number of system call
information. So we have two option to update NR_syscalls
value.

1. Update NR_syscalls in asm/unistd.h manually by count-
   ing the no.of system calls. No need to update NR_sys-
   calls until we either add a new system call or delete
   existing system call.

2. We can keep this feature in above mentioned script,
   that will count the number of syscalls and keep it in
   a generated file. In this case we don't need to expli-
   citly update NR_syscalls in asm/unistd.h file.

The 2nd option will be the recommended one. For that, I
added the __NR_syscalls macro in uapi/asm/unistd.h along
with NR_syscalls asm/unistd.h. The macro __NR_syscalls
also added for making the name convention same across all
architecture. While __NR_syscalls isn't strictly part of
the uapi, having it as part of the generated header to
simplifies the implementation. We also need to enclose
this macro with #ifdef __KERNEL__ to avoid side effects.

Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Firoz Khan authored and Michael Ellerman committed Dec 21, 2018
1 parent 2cd4bd1 commit 8a19eee
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 1 addition & 2 deletions arch/powerpc/include/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@

#include <uapi/asm/unistd.h>


#define NR_syscalls 389
#define NR_syscalls __NR_syscalls

#define __NR__exit __NR_exit

Expand Down
5 changes: 4 additions & 1 deletion arch/powerpc/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#ifndef _UAPI_ASM_POWERPC_UNISTD_H_
#define _UAPI_ASM_POWERPC_UNISTD_H_


#define __NR_restart_syscall 0
#define __NR_exit 1
#define __NR_fork 2
Expand Down Expand Up @@ -401,4 +400,8 @@
#define __NR_rseq 387
#define __NR_io_pgetevents 388

#ifdef __KERNEL__
#define __NR_syscalls 389
#endif

#endif /* _UAPI_ASM_POWERPC_UNISTD_H_ */

0 comments on commit 8a19eee

Please sign in to comment.