Skip to content

Commit

Permalink
driver core: silence device link messages unless debugging
Browse files Browse the repository at this point in the history
On platforms making a fair use of regulators, the dev_info() messages
coming from the device link function are a bit too verbose. The amount
of message will increase further with the clock framework joining the
device link party.

These messages looks valuable for people debugging device link related
issues, so dev_dbg() looks more appropriate than dev_info().

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jerome Brunet authored and Greg Kroah-Hartman committed Jan 22, 2019
1 parent 549ad24 commit 8a4b326
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/base/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ struct device_link *device_link_add(struct device *consumer,
list_add_tail_rcu(&link->s_node, &supplier->links.consumers);
list_add_tail_rcu(&link->c_node, &consumer->links.suppliers);

dev_info(consumer, "Linked as a consumer to %s\n", dev_name(supplier));
dev_dbg(consumer, "Linked as a consumer to %s\n", dev_name(supplier));

out:
device_pm_unlock();
Expand All @@ -328,8 +328,8 @@ static void __device_link_del(struct kref *kref)
{
struct device_link *link = container_of(kref, struct device_link, kref);

dev_info(link->consumer, "Dropping the link to %s\n",
dev_name(link->supplier));
dev_dbg(link->consumer, "Dropping the link to %s\n",
dev_name(link->supplier));

if (link->flags & DL_FLAG_PM_RUNTIME)
pm_runtime_drop_link(link->consumer);
Expand Down

0 comments on commit 8a4b326

Please sign in to comment.