Skip to content

Commit

Permalink
sky2: don't stop queue on shutdown
Browse files Browse the repository at this point in the history
It is unnecessary, to stop queue and turn off carrier in shutdown
routine. With new netdev_queue this causes warnings.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Jul 23, 2008
1 parent c010b2f commit 8a6d2ea
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -1829,9 +1829,6 @@ static int sky2_down(struct net_device *dev)
if (netif_msg_ifdown(sky2))
printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);

/* Stop more packets from being queued */
netif_stop_queue(dev);

/* Disable port IRQ */
imask = sky2_read32(hw, B0_IMSK);
imask &= ~portirq_msk[port];
Expand Down Expand Up @@ -1887,8 +1884,6 @@ static int sky2_down(struct net_device *dev)

sky2_phy_power_down(hw, port);

netif_carrier_off(dev);

/* turn off LED's */
sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);

Expand Down

0 comments on commit 8a6d2ea

Please sign in to comment.